Block publishing performance #8181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
approved these changes
Apr 10, 2024
| private final int latePublishingEventThreshold; | ||
| private final Function<UInt64, UInt64> slotTimeCalculator; | ||
|
|
||
| public BlockProductionAndPublishingPerformanceFactory( |
There was a problem hiding this comment.
I'd rename it to BlockPerformanceFactory
There was a problem hiding this comment.
mmm.. BlockPerformanceFactory seems a bit generic to me. We have the block import performance, so need something more specific...
There was a problem hiding this comment.
And there is a BlockPerformance class too. Well we could keep it then...
| @@ -221,7 +231,7 @@ public MetricsConfigBuilder blockPerformanceEnabled(final boolean blockPerforman | |||
| return this; | |||
| } | |||
|
|
|||
| public MetricsConfigBuilder blockProductionPerformanceEnabled( | |||
| public MetricsConfigBuilder blockProductionAndPublishingPerformanceEnabled( | |||
| final boolean blockProductionPerformanceEnabled) { | |||
There was a problem hiding this comment.
Should be renamed to blockProductionAndPublishingPerformanceEnabled too
| @@ -428,10 +428,14 @@ public UInt64 computeEpochAtSlot(final UInt64 slot) { | |||
| return atSlot(slot).miscHelpers().computeEpochAtSlot(slot); | |||
| } | |||
|
|
|||
| public UInt64 computeTimeAtSlot(BeaconState state, UInt64 slot) { | |||
| public UInt64 computeTimeAtSlot(final BeaconState state, final UInt64 slot) { | |||
| return atSlot(slot).miscHelpers().computeTimeAtSlot(state.getGenesisTime(), slot); | |||
There was a problem hiding this comment.
Could call the new wrapper computeTimeAtSlot(state.getGenesisTime(), slot)
| @@ -116,7 +116,7 @@ public class ValidatorApiHandler implements ValidatorApiChannel { | |||
| */ | |||
| private static final int DUTY_EPOCH_TOLERANCE = 1; | |||
|
|
|||
| private final BlockProductionPerformanceFactory blockProductionPerformanceFactory; | |||
| private final BlockProductionAndPublishingPerformanceFactory blockProductionPerformanceFactory; | |||
There was a problem hiding this comment.
Should be renamed accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockProductionPerformancetoo)BlockPublishingPerformanceto cover the last step of block production flowexamples:
Slow Block Production *** Slot: 1397723 start 10ms, preparation_on_tick +0ms, preparation_apply_deferred_attestations +0ms, preparation_process_head +200ms, retrieve_state +1ms, beacon_block_prepared +293ms, local_get_payload +23ms, builder_get_header +169ms, builder_bid_validated +4ms, beacon_block_created +1ms, state_transition +161ms, state_hashing +14ms, complete +0ms total: 866msSlow Block Publishing *** Slot: 1397723 start 882ms, builder_get_payload +2300ms, blob_sidecars_prepared +10ms, block_and_blob_sidecars_publishing_initiated +0ms, block_import_completed +1ms, complete +0ms total: 2311msfixes #5808
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog